Conversation
Generated-by: OpenAI Codex (GPT-5)
fallenmi
force-pushed
the
agent/fix-duplicate-log-propagation
branch
from
August 25, 2026 12:58
3046a92 to
43d804c
Compare
fallenmi
marked this pull request as ready for review
August 25, 2026 12:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenTAKServerlogger from propagating records to the root loggerRoot cause
OpenTAKServer configures handlers directly on its named logger, but the logger retained Python's default
propagate=True. When a dependency or runtime also configured the root logger, the same record was emitted by both handler chains.The named logger's existing file and TTY handlers are unchanged. In non-TTY environments, this intentionally removes the accidental bare root/stderr copy while preserving the configured file output.
Validation
.venv/bin/python -m pytest tests/test_logging.py -q(1 passed).venv/bin/python -m pytest -q(1 passed, 1 skipped).venv/bin/python -m black --check --line-ranges 13-13 opentakserver/extensions.py.venv/bin/python -m black --check tests/test_logging.py.venv/bin/python -m isort --check-only opentakserver/extensions.py tests/test_logging.py.venv/bin/python -m flake8 opentakserver/extensions.py tests/test_logging.pygit diff --check origin/master...HEADThanks to @TX-RX for the clear report and suggested direction.
Fixes #304
Generated-by: OpenAI Codex (GPT-5)