Export generated validate proto artifacts - #152
Conversation
|
Any time for a review @timostamm @jonbodner-buf ? |
|
Thanks for the PR! It fails CI for two reasons:
To land this, the best way forward is to drop the change to the example for now, and fix the exports so that Please also see #151 (comment) for details, especially the file extension for the exports, which should be |
|
Thanks @timostamm I have implemented the two changes you recommend. I could not get |
|
TS 7 support is a different bridge to cross. Node10 resolution can be satisfied via typesVersions, see https://github.com/bufbuild/protobuf-es/blob/6d0c4448cd4fc17751099603f5c60a08dfe4a5be/packages/protobuf/package.json#L125 for an example. |
timostamm
left a comment
There was a problem hiding this comment.
We'll need to do some more testing before we can release it, but let's get this merged!
This PR implements the feature request described by #151.
The generated file
buf/validate/validate_pb.tsis now available as an export from@bufbuild/protovalidate/gen. The full import is@bufbuild/protovalidate/gen/buf/validate/validate_pb.js.