Fix fuel accounting in tests on MacOS - #1243
Merged
Merged
Conversation
jeffcharles
marked this pull request as ready for review
July 28, 2026 17:31
saulecabrera
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
There shouldn't be any functional changes. This just adjusts how we initialize modules in tests so we consistently use a file-backed initialization image that skips copying active data segments into linear memory.
Why am I making this change?
The tests stopped passing on MacOS due to fuel consumed becoming much higher after we updated to Wasmtime 46. Wasmtime 46, in this change, started executing startup code in Wasm instead of in the host environment. On Linux, this doesn't really make a difference to fuel accounting in practice. On MacOS however, the startup function performs operations to copy memory. I've put a comment in the code change explaining the details.
Checklist
javy-plugin-apiif the QuickJS bytecode has changed.javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.