Add --fail-on-error option to host link command #269

Activity

1. kraenhansen

   added

   enhancementNew feature or requestNew feature or request

   good first issueGood for newcomersGood for newcomers

   Host 🏡Our `react-native-node-api-modules` packageOur `react-native-node-api-modules` package

   Linking 🔗Discovering and copying prebuilds from packages into the hostDiscovering and copying prebuilds from packages into the host

   on Oct 18, 2025
2. huytdps13400 commented on Aug 23, 2026

   

   huytdps13400

   on Aug 23, 2026

   More actions

   /claim

   I reproduced the current behavior with a CLI integration fixture whose dependency has a broken exports target. Default link --android still succeeds and warns, while the new --fail-on-error expectation is red because the option does not exist yet.

   I’ll keep the default compatibility behavior, thread the opt-in flag through the link discovery path so the original resolution error is rethrown, and verify the real CLI exit/output plus the host/root test gates.
3. huytdps13400 commented on Aug 23, 2026

   

   huytdps13400

   on Aug 23, 2026

   More actions

   Implemented in #453.

   The new link --fail-on-error mode surfaces the original package-resolution error and exits non-zero, while the default link behavior remains compatible and continues to warn/skip. The CLI integration regression covers both paths with a broken exports fixture.

   Verification: focused CLI 4/4, host 63/63, and the full root matrix 109/109; build, lint, Prettier, depcheck, runtime help, and diff checks all pass on Node 24.16.0 / pnpm 10.33.0.