Skip to content

feat(core): a standalone worker serves agent-device on localhost by default - #967

Merged
V3RON merged 13 commits into
task/956from
task/957
Oct 24, 2026
Merged

V3RON merged 13 commits into
task/956from
task/957

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #957

Status

Implement: done (6/6 green) Review: round 2 + fix-check passed Hardware: profile case pass; full file blocked by pre-existing #971 Gate: not run (maintainer asked to stop before the gate)

  • pnpm exec vitest run --project unit <file> passes for src/core/config.test.ts, src/agent-device/definition.test.ts, src/agent-device/edge.test.ts and src/daemon/main.test.ts with the lines above: run by the build and audit; the doctor.run cases wait for starting to end.
  • pnpm test:e2e passes for the e2e files the harness change touches. CI is green: three fast e2e files run by the audit; CI green on 7253fbc (23 pass).
  • Slow lane: scripts/slow-e2e.sh e2e/slow-agent-device.test.ts passes, including the profile case: the profile case passes on iOS and Android; the file still fails one sharding case, which fails the same way on main (agent-device sharding with no --device fails: the front rewrites --device to the UDID #971).
  • The website build passes, and the docs state the new defaults: audit run; claims lens found every changed claim true.

Feature #952 Completion conditions:

Assumptions

  • Assumption: the profile's clientId value — a constant 16-hex id (a51a51a51a51a51a) in the shape of agent-device's own generated profiles, so the file's bytes stay stable; agent-device 0.21.28 refuses a proxy open without one (decision comment on this PR).

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 18.5M.
Runs: 13. Cost USD: 6.6777. Agent seconds: 5579.

Assessment: complete

Written by an agent.

@V3RON
V3RON added this pull request to stack #965 October 23, 2026 20:44
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Decision taken

Question: the slow lane showed that agent-device 0.21.28 refuses open through the proxy when the profile has no clientId: INVALID_ARGS "Proxy open requires leaseId, tenantId, runId, clientId, and deviceKey lease metadata." (details.missing ["clientId"]). The spec's key list for the profile (#956, ADR 0046 §2) leaves clientId out.

Options:

  • Add a constant clientId to the profile. A user sees open work. The file's bytes stay stable, so saved connections survive restarts.
  • Add a random clientId per install, kept in the file. This also works, but it is one more value to keep stable.

Taken: a constant. It is the smallest change and keeps the "rewrite only when bytes change" rule simple. agent-device's own generated proxy profiles carry a clientId too.

Reverting: drop the key. open then fails again.

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 3f91e4e
Round 2: cedc119
Round fix-check: 7253fbc

Runs: 13. Cost USD: 6.6777. Agent seconds: 5579.
Tokens input 562, output 127615, cache read 22336560, cache write 955413.
- build implementer: claude-sonnet-5-5 1642 s $2.6043
- audit implementer: claude-sonnet-5-5 466 s $0.4365
- review 1 reviewer: claude-sonnet-5-5 428 s $0.3446
- review 1 spec: claude-sonnet-5-5 62 s $0.3422
- review 1 code both: claude-opus-5-5 334 s $1.5566
- review 1 claims: claude-sonnet-5-5 49 s $0.2626
- fix 1 implementer: claude-sonnet-5-5 57 s $0.1112
- review 2 reviewer: claude-sonnet-5-5 26 s $0.0752
- hardware hardware-verifier: claude-sonnet-5-5 243 s $0.0899
- hardware-fix implementer: claude-sonnet-5-5 276 s $0.1327
- hardware hardware-verifier: claude-sonnet-5-5 1494 s $0.2526
- hardware-fix implementer: claude-sonnet-5-5 426 s $0.3079
- review fix-check reviewer: claude-sonnet-5-5 76 s $0.1614
Finding outcomes: {"fixed":1}. Classes: {"harness pin dropped by shallow capabilities override":1}.
{
 "findings": [
  {
   "id": "R1",
   "role": "code",
   "class": "harness pin dropped by shallow capabilities override",
   "outcome": "fixed",
   "path": "e2e/console/fixtures.ts",
   "round": "1",
   "fix": "cedc1199f522f62f0aede463939c9bb158f6dcc4"
  }
 ]
}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 21:49
@V3RON
V3RON merged commit a8de7d3 into main Oct 24, 2026
62 checks passed
@V3RON
V3RON deleted the task/957 branch October 24, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A standalone worker serves agent-device on localhost by default

1 participant