Repository navigation
Conversation
V3RON
added this pull request to stack #965
October 23, 2026 20:44
Contributor
Author
Decision takenQuestion: the slow lane showed that agent-device 0.21.28 refuses Options:
Taken: a constant. It is the smallest change and keeps the "rewrite only when bytes change" rule simple. agent-device's own generated proxy profiles carry a Reverting: drop the key. Written by an agent. |
…t-device requires (#957)
Contributor
Author
Review ledgerRound 1: 3f91e4e {
"findings": [
{
"id": "R1",
"role": "code",
"class": "harness pin dropped by shallow capabilities override",
"outcome": "fixed",
"path": "e2e/console/fixtures.ts",
"round": "1",
"fix": "cedc1199f522f62f0aede463939c9bb158f6dcc4"
}
]
}Written by an agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #957
Status
Implement: done (6/6 green) Review: round 2 + fix-check passed Hardware: profile case pass; full file blocked by pre-existing #971 Gate: not run (maintainer asked to stop before the gate)
pnpm exec vitest run --project unit <file>passes forsrc/core/config.test.ts,src/agent-device/definition.test.ts,src/agent-device/edge.test.tsandsrc/daemon/main.test.tswith the lines above: run by the build and audit; the doctor.run cases wait forstartingto end.pnpm test:e2epasses for the e2e files the harness change touches. CI is green: three fast e2e files run by the audit; CI green on 7253fbc (23 pass).scripts/slow-e2e.sh e2e/slow-agent-device.test.tspasses, including the profile case: the profile case passes on iOS and Android; the file still fails one sharding case, which fails the same way onmain(agent-device sharding with no --device fails: the front rewrites --device to the UDID #971).Feature #952 Completion conditions:
--session,connect --force, noconfig set: feat(modules): a standalone worker writes a private agent-device profile for local agents #963 and this PR.Assumptions
clientIdvalue — a constant 16-hex id (a51a51a51a51a51a) in the shape of agent-device's own generated profiles, so the file's bytes stay stable; agent-device 0.21.28 refuses a proxyopenwithout one (decision comment on this PR).Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 18.5M.
Runs: 13. Cost USD: 6.6777. Agent seconds: 5579.
Assessment: complete
Written by an agent.