Repository navigation
Conversation
…re the tool reads it (#620)
V3RON
added this pull request to stack #970
October 23, 2026 21:10
Contributor
Author
Review ledgerRound 1: 8cfbe3f {"findings":[
{"id":"R1","role":"code","class":"testing 3","outcome":"fixed","path":"src/instructions/setup.ts","round":"1","fix":"277f89373"},
{"id":"R2","role":"code","class":"architecture 10","outcome":"fixed","path":"src/cli/commands/setup.ts","round":"1","fix":"277f89373"}
]}Written by an agent. |
V3RON
marked this pull request as ready for review
October 23, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620
Status
Implement: done (9/9 green) Audit: complete Review: round 2 passed, 2 findings fixed Hardware: n/a Gate: waiting for the stack (#960 → #969)
Next: stack sync and gate for #157, when the maintainer says so
Done when
pnpm test:e2e e2e/setup.test.tspasses: the skill lands at the documented place for each scope, and MCP is connected through the tool's command. (e2e/setup.test.ts)simlock setup --tool claude-code, then--tool codex, then starting each tool lists thesimlockskill, and asking the agent to use a simulator makes it runsimlock whoamiandsimlock instructions. (Maintainer's manual check; not run.)simlock --helplistssetup. (src/cli/index.tsUSAGE; asserted insrc/cli/index.test.ts)reference/cli.mdx,reference/errors.mdxandconnect-your-agent.mdxdescribe the command, both tools, both scopes, the paths and the two error codes.pnpm checkis green. (CI on 79425f2 running; the gate checks it.)Feature #157 Completion conditions: the CLI, MCP, text-content and website conditions are delivered by #960; the
setupconditions (scopes, re-run, refusal, MCP connect, no daemon) by this PR's tests. The by-hand tool check above is still open.Assumptions
setupneeds a filesystem from the CLI environment —CliEnvironmentgainsfilesystem(already a port ofbuildCliEnvironment) beside the fields the spec lists.renderSkilllives insrc/instructions/skill.tsand is re-exported byindex.ts— avoids an import cycle betweenindex.tsandsetup.ts.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 12.2M.
Runs: 9. Cost USD: 5.6963. Agent seconds: 3230.
Assessment: complete
Written by an agent.