Repository navigation
feat(drivers): device.exec fills in the lease's device and refuses another - #972
Merged
Merged
Conversation
V3RON
added this pull request to stack #973
October 24, 2026 06:24
V3RON
marked this pull request as ready for review
October 24, 2026 06:49
Contributor
Author
Review ledgerRound 1: ac9187b {"findings":[
{"id":"R1","role":"claims","class":"architecture 13 doc claim false","outcome":"fixed","fix":"473d52b95a2ea25c67702823551b9dbc5ebdb1fd","path":"website/src/content/docs/docs/using-devices/remote-agents.mdx","round":"1"},
{"id":"R2","role":"code","class":"testing 3 reconnect alone unproven","outcome":"nonblocking","path":"src/drivers/android/index.ts","round":"1"},
{"id":"R3","role":"code","class":"documentation 9 gateway guide not updated","outcome":"nonblocking","path":"website/src/content/docs/docs/using-devices/working-with-a-device.mdx","round":"1"},
{"id":"R4","role":"code","class":"documentation 7 manual incomplete","outcome":"nonblocking","path":"src/drivers/ios/AGENTS.md","round":"1"}
]}Assessment: complete Written by an agent. |
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
6 of 7 tasks
V3RON
added a commit
that referenced
this pull request
Oct 24, 2026
Closes #959 ### Status Implement: done (7/7 green) Review: passed (round 1) Hardware: n/a Gate: waiting for the stack Next: stack gate - [ ] `pnpm check` is green. Checked by CI on the stack's head before the gate. - [x] The seven Tests lines pass in `pnpm test`, in `src/mcp/server.test.ts` and `src/instructions/index.test.ts`. Probed by the audit, 7/7. - [x] `connect-your-agent.mdx` lists five tools, describes `run_on_device`'s result and `NO_LEASE`, and no longer says the MCP tools do not run commands; `reference/cli.mdx` and `introduction/index.mdx` name five tools; `src/mcp/AGENTS.md` describes the tool and that it does not queue; the instructions text's MCP section names `run_on_device`. Checked by the audit and the claims review. Feature #951 Completion conditions: - [x] `run_on_device` runs `simctl install`, `simctl launch` and `adb shell` with no device id and returns stdout, stderr and exit code: `src/mcp/server.test.ts` (tool to daemon) and #972's driver fill-in tests. Not run on a real device. - [x] `POST /v1/leases/{id}/exec` installs on the lease's device and refuses `booted` with `PASSTHROUGH_REFUSED`: #972's simctl fill-in and refusal tests at the driver seam the route calls. - [x] `run_on_device` without a lease answers `NO_LEASE`: `src/mcp/server.test.ts`. - [x] The MCP and remote-agents pages describe both: `connect-your-agent.mdx` (here), `remote-agents.mdx` (#972). ## Assumptions none ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 0 fixed, 1 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 11.3M. Runs: 6. Cost USD: 3.2105. Agent seconds: 1543. Assessment: complete Rejected: - code: the `lease_status` test fails by timeout, not on an assertion, when `run_on_device` goes back on the queue (src/mcp/server.test.ts:881) — [incorrect] a hung `lease_status` is the failure its title names *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #958
Status
Implement: done (5/5 green) Review: passed (round 1 + claims fix-check) Hardware: n/a Gate: waiting for the stack
Next: stack gate after #959
pnpm checkis green (toolchain.md). Checked by CI on the stack's head before the gate.pnpm test. The driver tests:src/drivers/ios/index.test.ts,src/drivers/ios/devicectl-passthrough.test.ts,src/drivers/android/index.test.ts.booted, and say a command naming another device is refused. Checked by the audit and the claims review.docs/internal/flows/device-exec.md, both driver manuals and the two comments in Modules touched describe the fill-in. Checked by the claims review.Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 0 fixed, 3 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: 9.6M.
Assessment: complete
Runs: 11. Cost USD: 4.8461. Agent seconds: 2407.
Rejected:
reconnectalone orforward tcp:…getting-s(src/drivers/android/index.ts:415) — [nonblocking] no Tests line asks for it; the fill-in is proven byshell getpropandinstallWritten by an agent.