feat: add support for RISC-V architecture

[vhaudiquet]

Original MP on Launchpad: https://code.launchpad.net/~vhaudiquet/maas/+git/maas/+merge/501672

WIP: Add support for riscv64 architecture

I added support for riscv64 architecture on 3.7, and used it to network boot a RISC-V board, the VisionFive 2. With custom-built maas-images, and a small diff to maas-ui, I could see RISC-V images in the UI, see my VisionFive2 board, and boot it properly via MAAS.

I rebased the modifications onto master directly.

This is still experimental, but some parts might be directly mergeable. For example, code matching architecture string to debian architecture: it already has riscv64 in some places, but not everywhere.

It might be a bit too agressive as I added riscv64 everywhere I thought it was missing. Someone needs to check if this does not break stuff on other arches, but otherwise it did work on riscv64 during my experiments.

I also only added UEFI TFTP boot on riscv64, and not HTTP boot.

[maas-lander]

Check where you would like a Mattermost message to be sent to when CI completes and this PR is merged

• Direct message
• ~maas

[r00ta]

can you please run make format && make lint and push if it's successful?

[vhaudiquet]

Now lint is passing but there seems to be a lot of test errors.

[vhaudiquet]

For testing purposes, I also modified maas-images and maas-ui.

For maas-images I had the following diff:

diff --git a/conf/bootloaders.yaml b/conf/bootloaders.yaml
index d788a6a..e1b15ac 100644
--- a/conf/bootloaders.yaml
+++ b/conf/bootloaders.yaml
@@ -41,6 +41,16 @@ bootloaders:
     - usr/lib/shim/shimaa64.efi.signed.latest, bootaa64.efi
     - usr/lib/shim/mmaa64.efi, mmaa64.efi
     - usr/lib/grub/arm64-efi-signed/grubnetaa64.efi.signed, grubaa64.efi
+ - firmware-platform: uefi
+   packages:
+    - grub-efi-riscv64-bin
+   arch: riscv64
+   arches: riscv64
+   archive: http://ports.ubuntu.com
+   release: noble
+   os: grub-efi
+   files:
+    - usr/lib/grub/riscv64-efi/monolithic/grubnetriscv64.efi, grubriscv64.efi
  - firmware-platform: open-firmware
    packages:
     - grub-ieee1275-bin

For maas-ui I had the following diff:

diff --git a/src/app/apiclient/types.gen.ts b/src/app/apiclient/types.gen.ts
index 6fa5bb4c3..ae243a609 100644
--- a/src/app/apiclient/types.gen.ts
+++ b/src/app/apiclient/types.gen.ts
@@ -1112,6 +1112,7 @@ export type KnownArchesEnum =
   | "armhf"
   | "i386"
   | "ppc64el"
+  | "riscv64"
   | "s390x";

 /**
diff --git a/src/app/store/general/types/base.ts b/src/app/store/general/types/base.ts
index c1d996d47..f9fe589e6 100644
--- a/src/app/store/general/types/base.ts
+++ b/src/app/store/general/types/base.ts
@@ -113,6 +113,7 @@ export type KnownArchitecture =
   | "armhf"
   | "i386"
   | "ppc64el"
+  | "riscv64"
   | "s390x";

 export type KnownArchitecturesState = {

I'm not sure this is super helpful but just FYI 😃

[vhaudiquet]

Thanks for the review @bjornt. My approach must have been a bit too agressive as I added riscv64 everywhere I saw other architectures present, sometimes without understanding the purpose of the files. I will remove from src/maasserver/migrations/maasserver/* as well as src/maasservicelayer/db/alembic/versions/0000_initial.py.

[vhaudiquet]

I pushed an update to the tests that should fix all failures hopefully 😃

[vhaudiquet]

Rebased the PR on top of master

[bjornt]

/review

[bjornt]

Looks good to me, thanks for the contribution!

[vhaudiquet]

I'm not sure I understand why "ci-check" and "test-python" are passing in CI and failing in merge queue? Is that a real failure that surfaced somehow or an infrastructure / temporary error?

I tried to check the logs but they don't seem related to the PR:

src/tests/maasapiserver/v3/api/public/models/requests/test_ipranges.py::TestIPRangeCreateRequest::test_mandatory_params
  src/tests/maasapiserver/v3/api/public/models/requests/test_ipranges.py:60: PytestWarning: The test <Function test_mandatory_params> is marked with '@pytest.mark.asyncio' but it is not an async function. Please remove the asyncio mark. If the test is not marked explicitly, check for global marks applied via 'pytestmark'.
    def test_mandatory_params(self):

[wyattrees]

@vhaudiquet it looks like test-python failed due to a flaky test (ci-check only failed because test-python did). In this case we just need to try again. I've added this back into the queue.