Skip to content

Enable integration tests for wait-online logic - #546

Merged
JegadishD merged 1 commit into
canonical:mainfrom
slyon:enable-wait-online-tests
Sep 1, 2026
Merged

JegadishD merged 1 commit into
canonical:mainfrom
slyon:enable-wait-online-tests

Conversation

@slyon

@slyon slyon commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

Description

Follow-up to #535 which can only be landed after the upstream Netplan CI got upgraded to systemd v258. Or Noble received backports of the relevant wait-online changes, as landed in https://launchpad.net/ubuntu/+source/systemd/257.2-3ubuntu1

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad.

@slyon

slyon commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

needs to be rebased on top of #552

@slyon
slyon force-pushed the enable-wait-online-tests branch from 085b0f9 to 74c1573 Compare January 12, 2026 15:39
@JegadishD JegadishD added the review-list review-list tag is applied to PR that are to be considered for review with priority. label Jul 1, 2026
@JegadishD

Copy link
Copy Markdown
Collaborator

@slyon
Major part of this PR is already merged and taken care by your earlier work - https://github.com/canonical/netplan/pull/566/changes
The only pending change to be merged from this PR is the change to enable to networkd-wait-online.service (tests/integration/ethernets.py)

Can you please update the PR or please let me know, I am open to update it from my end.

@slyon

slyon commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

@JegadishD Thanks for getting the CI updated to 26.04, unblocking this additional test!

Please feel free to move ahead with this yourself. IIRC all it needs should be a cherry-pick of that single commit, which we're currently carrying as a distro-patch in Debian/Ubuntu: https://sources.debian.org/src/netplan.io/1.2.2-1/debian/patches/0001-tests-ethernets-enable-wait-online-intergration-test.patch

@JegadishD
JegadishD force-pushed the enable-wait-online-tests branch from 74c1573 to d80f1b1 Compare September 1, 2026 07:00
@JegadishD
JegadishD self-requested a review September 1, 2026 07:01
@JegadishD

Copy link
Copy Markdown
Collaborator

@slyon Thanks for the reply. I have updated the PR with only the specific change required. The GitHub workflows are all passing. I shall be merging it shortly!

@JegadishD
JegadishD merged commit e702665 into canonical:main Sep 1, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-list review-list tag is applied to PR that are to be considered for review with priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants