Skip to content

Issue #140: Added explicit parameters for str_getcsv() #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micoreyes merged 1 commit into from
Jul 17, 2026
Merged

Issue #140: Added explicit parameters for str_getcsv() #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/file_search.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ public static function make_where_clause(object $criteria): array {
*/
public static function get_id_from_csv(string $line): int {
// Interpret the last line as a csv line.
$csv = str_getcsv($line);
$csv = str_getcsv($line, ",", "\"", "\\");
// Check a few columns to ensure we have a valid line.
if (empty($csv[self::CSV_CONTEXTID])) {
return 0;
Expand Down
Loading