Repository navigation
Add missing <new> includes for placement new - #3236
Open
gburgessiv wants to merge 1 commit into
Open
gburgessiv wants to merge 1 commit into
gburgessiv wants to merge 1 commit into
Conversation
These files use placement `new` without directly including `<new>`, causing standalone compilation to fail if `<new>` is not included transitively.
gburgessiv
marked this pull request as ready for review
November 11, 2026 20:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3236 +/- ##
==========================================
- Coverage 91.41% 91.38% -0.03%
==========================================
Files 205 205
Lines 9106 9106
==========================================
- Hits 8324 8321 -3
- Misses 782 785 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What: These files use placement
newwithout directly including<new>, causing compilation to fail if<new>is not included transitively.Why (now): Might as well plug a few holes on
develwhile I'm here to patch the 2.x branch? (#3235)