Repository navigation
README: download the published SN94 policy in setup (bootstrap 4) - #320
Merged
Merged
Conversation
#318 dropped --snp-policy from the README, but the published installer is still bootstrap 4, whose setup requires it. Until bootstrap 5 is out, the README downloads deploy/validator-update/sn94-snp-policy.json and passes it, for systemd and Docker alike.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the README work today. #318 removed
--snp-policyfrom the setup command, but fresh installs still get bootstrap 4, and its setup requires the flag. Anyone following main would have failed.deploy/validator-update/sn94-snp-policy.json(byte-identical to the live mainnet policy) and passes--snp-policy /root/sn94-snp-policy.json.pytest -q tests/thin/test_operator_docs_safety.py: 15 passed.Note
Low Risk
README-only changes to installation and Docker instructions; no runtime or security logic is modified.
Overview
Updates operator docs so bootstrap 4 installs succeed again: setup must pass
--snp-policy, which had been dropped from the README while the signed bootstrap still required it.What you need now points at the repo-published policy (
deploy/validator-update/sn94-snp-policy.json) instead of a policy bundled in the signed bootstrap. Install adds an HTTPScurlstep to write/root/sn94-snp-policy.jsonand passes--snp-policytocathedral-validator-setup. The Docker example mounts that same path at/etc/cathedral/snp-policy.json, with wording aligned to the install flow.Reviewed by Cursor Bugbot for commit 71ba7c1. Bugbot is set up for automated code reviews on this repo. Configure here.