Repository navigation
Match complete option names in environment defaults - #617
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change preventing partial option-name matches in environment defaults.
No open issues 🎉
What changed in this PR
Fixes #616 by requiring a complete option-name match when reading environment defaults, so querying --foo no longer consumes part of --foobar as its value.
Changes:
- Requires whitespace or end of input after the requested option name.
- Adds regression tests for overlapping names, exact matches, and a flag at the end of input.
| File | Description |
|---|---|
src/test/java/com/beust/jcommander/defaultprovider/EnvironmentVariableDefaultProviderTest.java |
Adds option-boundary regression tests. |
src/main/java/com/beust/jcommander/defaultprovider/EnvironmentVariableDefaultProvider.java |
Adds a boundary check to the option-matching pattern. |
Review effort: Balanced
mkarg
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require an option-name boundary before reading its environment-provided value. With only --foobar present, querying --foo now returns null instead of consuming the suffix as a value.
Covers overlapping names, exact matches, and a flag at the end of the input. ./gradlew check passes all 341 tests on Java 21.
Fixes #616.