fix: call parent::tearDown() in ConsumerRunnerTest teardown - #65
Merged
trearcul merged 1 commit intoAug 25, 2026
Merged
Conversation
tearDown() called parent::setUp(), a typo dating back to 42a901b. This is a no-op change in practice: the parent is PHPUnit's TestCase, whose setUp() and tearDown() are both empty, and the actual cleanup is done by clearRabbitMQ() just above. Correcting it keeps the hook honest so it does not misbehave if a base class is introduced later.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 51.98% 52.46% +0.47%
==========================================
Files 29 29
Lines 654 650 -4
==========================================
+ Hits 340 341 +1
+ Misses 314 309 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect PHPUnit lifecycle call in ConsumerRunnerTest so the test suite properly runs teardown logic after each test.
Changes:
- Replace an erroneous
parent::setUp()call insidetearDown()withparent::tearDown().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
judzi
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.