You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
image-builder: select composefs from bootc's composefs-backend install config #29
Follow-up to cgwalters-forge/bootc#23 (bootc [install] composefs-backend key). osbuild's org.osbuild.bootc.install-to-filesystem stage runs bootc install inside the image, so bootc honors the key, but image-builder only sets ComposeFS / skips the ostree deployment mount when UnifiedKernel is true (pkg/manifest/raw_bootc.go:169-208). For a BLS image with the key, the first customization stage then fails in org.osbuild.ostree.deployment ("Could not find deployment"). Fix: add composefs-backend to BootcInstallConfiguration (pkg/bootc/resolver.go, parsed from bootc install print-configuration) and treat it like UnifiedKernel for backend selection; the customizations on composefs still need bootc install mount (bootc#2483), see triage https://gist.github.com/cgwalters-bot/b0baccf1e226e022822655cb5bb269a8. osbuild/images was renamed osbuild/image-builder.
The Composefs Stable board's copy of this item said:
Follow-up to cgwalters-forge/bootc#23 (the bootc [install] composefs-backend key). image-builder only picks the composefs path when UnifiedKernel is true (pkg/manifest/raw_bootc.go), so a BLS image that sets the key fails in org.osbuild.ostree.deployment. Fix: read composefs-backend from bootc install print-configuration into BootcInstallConfiguration and treat it like UnifiedKernel for backend selection. Customizations on composefs still need bootc install mount (bootc-dev/bootc#2483).
Triage (25 Oct 2026): still no job plan. Nothing has changed since the 24 Oct triage, and this still needs your choice of A, B or C from the 22 Oct triage.
I checked again. osbuild/image-builder main is still 9b0a582, so ComposeFS and skipping org.osbuild.ostree.deployment are still gated only on UnifiedKernel. The bug is still real (I read the code; I did not rebuild an image). The fix in the issue body is still obsolete, because bootc has no composefs-backend key now and picks the backend from the image. osbuild/osbuild#2575 is still closed in favour of HMS-11501. cgwalters-forge/image-builder#7 (last updated 7 Oct) and its base cgwalters-forge/image-builder#2 (30 Sep) are both still open, with review required.
Reply with B and I will post an implement plan stacked on cgwalters-forge/image-builder#2. That plan would detect a composefs-native image from /usr/lib/composefs/setup-root-conf.toml with no ostree prepare-root.conf, treat it like UnifiedKernel, and refuse customizations. Reply with A or C to park this until HMS-11501 lands.
Question for the operator (from the audit of the needs-human queue): image-builder composefs detection: (B) bot plans a fix stacked on forge image-builder#2 that detects composefs-native images, or (A/C) park until HMS-11501 lands?
The board's Why for this item was: Review ib#7 (human-text: your title/body/commit text, then /promote --human-text): bootc.deployment for post-install stages when the build root's bootc has install mount (probed with --help), ostree.deployment otherwise; supersedes ib#4/#6, stacked on ib#2, needs osbuild#1. Result: composefs, ostree (new bootc) and ostree (released bootc, fallback) disks boot with customizations on a 16-core devspace; pxe-tar-xz builds unchanged but fails to boot in ostree-prepare-root with upstream main too.
Closing as not planned: as of 27 Oct the body's fix is obsolete, and the real fix waits on HMS-11501 outside our repositories. Reopen if that lands and image-builder still needs a change.
Activity
cgwalters-bot commentedon Sep 26, 2026
The Composefs Stable board's copy of this item said:
12 remaining items
cgwalters-bot commentedon Oct 25, 2026
Dispatched the plan in #29 (comment): run.
cgwalters-bot commentedon Oct 25, 2026
Triage (25 Oct 2026): still no job plan. Nothing has changed since the 24 Oct triage, and this still needs your choice of A, B or C from the 22 Oct triage.
I checked again. osbuild/image-builder main is still 9b0a582, so
ComposeFSand skippingorg.osbuild.ostree.deploymentare still gated only onUnifiedKernel. The bug is still real (I read the code; I did not rebuild an image). The fix in the issue body is still obsolete, because bootc has nocomposefs-backendkey now and picks the backend from the image. osbuild/osbuild#2575 is still closed in favour of HMS-11501. cgwalters-forge/image-builder#7 (last updated 7 Oct) and its base cgwalters-forge/image-builder#2 (30 Sep) are both still open, with review required.Reply with B and I will post an implement plan stacked on cgwalters-forge/image-builder#2. That plan would detect a composefs-native image from
/usr/lib/composefs/setup-root-conf.tomlwith no ostreeprepare-root.conf, treat it likeUnifiedKernel, and refuse customizations. Reply with A or C to park this until HMS-11501 lands.Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 26, 2026
Question for the operator (from the audit of the needs-human queue): image-builder composefs detection: (B) bot plans a fix stacked on forge image-builder#2 that detects composefs-native images, or (A/C) park until HMS-11501 lands?
The board's Why for this item was: Review ib#7 (human-text: your title/body/commit text, then /promote --human-text): bootc.deployment for post-install stages when the build root's bootc has install mount (probed with --help), ostree.deployment otherwise; supersedes ib#4/#6, stacked on ib#2, needs osbuild#1. Result: composefs, ostree (new bootc) and ostree (released bootc, fallback) disks boot with customizations on a 16-core devspace; pxe-tar-xz builds unchanged but fails to boot in ostree-prepare-root with upstream main too.
Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 27, 2026
Parked until HMS-11501 lands: the body's fix is obsolete, and stacking more work on the unreviewed forge image-builder#2 and #7 adds little.
Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 30, 2026
Closing as not planned: as of 27 Oct the body's fix is obsolete, and the real fix waits on HMS-11501 outside our repositories. Reopen if that lands and image-builder still needs a change.
Generated-by: https://github.com/cgwalters/#llms