Repository navigation
fix(ci): bind the publish index to the deployment environment and allow production PyPI only from release tags - #88
Merged
Conversation
…only from release tags
chad-loder
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly still passed the publish action's old input names; GitHub only warns on unknown inputs, so
index-hostdefaulted topypi.organd the nightly attempted a production upload (PyPI rejected it: no publisher for nightly.yml). Now the destination is the environment variablePYPI_INDEX_HOST(pypienv: pypi.org;testpypienv: test.pypi.org),index-hosthas no default, andpypi.orgis refused unless the ref is av*tag.