Repository navigation
test(e2e): speed up device-flow login e2e on Windows by setting SHELL [RED-1187] [ship] - #1546
Merged
Merged
Conversation
…werShell probe [RED-1187] The spec spawns the CLI with a stripped env and no SHELL, so on Windows @oclif/core's getShell() runs `powershell -Command Get-CimInstance` on every command. That cost ~33 s per CLI run and pushed the file near its per-test timeouts. checklyEnv already sets SHELL for the same reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sorccu
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: RED-1187
Summary
login-device-flow.spec.tsspawns the CLI withextendEnv: falseand its own env, which leavesSHELLunset. On Windows,@oclif/core'sgetShell()then runspowershell -NoProfile -Command Get-CimInstance …on every command to detect the parent shell. That costs about 33 s per CLI run on the Windows runners: 788 s for the file's 9 tests, with one test timing out at 180 s.checklyEnvine2e/run-checkly.tsalready setsSHELLfor this reason (#1357). This spec builds its env by hand, so it never got the fix. It is the only e2e spec with a stripped env that does not setSHELL.The fix sets
SHELLthe same waychecklyEnvdoes. This doesn't affect Linux or macOS, whereos.userInfo().shellalready gives oclif a value without spawning anything. Locally (macOS) the whole file runs in 12 s, about 0.3 s per CLI run.Test plan
login-device-flow.spec.tspasses locally🤖 Generated with Claude Code