Repository navigation
fix(cli): keep JSON string and null bodies intact in checkly api [RED-1269] [ship] - #1581
Merged
Merged
Conversation
…-1269] A top-level JSON string was printed without its quotes, so --jq failed to parse it, and a JSON null body was mistaken for an empty body and dropped. Every parsed JSON value now goes through formatJson, and only a zero-length body counts as empty. Fixes #1575 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sorccu
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: RED-1269
Fixes #1575
checkly apimishandled two validapplication/jsonbodies:"ok") was printed without its quotes, so--jqfailed withparse error: Invalid literal. The string shortcut predates fix: preserve binary response bytes in api command #1502; since then non-JSON bodies take a separate branch, so the shortcut only ever stripped quotes from real JSON strings.nulldoubled as the empty-body sentinel, so anullbody printed nothing and--jqwas skipped.Every parsed JSON value now goes through
formatJson, and only a zero-length body counts as empty (a 204 still prints nothing).New specs in
api-output.spec.tscover string andnullbodies with and without--jq; all four fail onmain.🤖 Generated with Claude Code