Skip to content

Release 8.2.1 - Oauth scopes review - #668

Merged
david-ruiz-cko merged 2 commits into
masterfrom
release/8.2.1
Sep 16, 2026
Merged

david-ruiz-cko merged 2 commits into
masterfrom
release/8.2.1

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release updates the OAuthScope enum to synchronize it with the latest Checkout.com API specification, ensuring all documented OAuth 2.0 scopes are present and correctly named. It adds missing scopes, removes deprecated ones, and improves test coverage to catch future discrepancies. Additionally, integration tests are updated to use the correct, current scopes.

OAuthScope enum synchronization and improvements:

  • Added missing OAuth 2.0 scopes (e.g., DISPUTES_SCHEME_FILES, FLOW_REFLOW, ISSUING_DISPUTES, VAULT_CUSTOMERS, VAULT_GPAYME_ENROLLMENT, VAULT_TOKENS_METADATA, compliance-related scopes, etc.) and removed deprecated/retired ones (e.g., MARKETPLACE, ISSUING_CARD_MGMT, ISSUING_CLIENT, FORWARD, FORWARD_SECRETS) to match the API spec. [1] [2] [3]
  • Clarified the distinction between PAYMENT_CONTEXT and GATEWAY_PAYMENT_CONTEXTS scopes, correcting previous naming and value mismatches.
  • Updated enum documentation to explain scope origins, naming, and special cases for easier maintenance.

Test enhancements:

  • Added comprehensive tests to ensure all enum constants have non-blank, unique wire values, and that the enum is maintained in alphabetical order.
  • Added tests to verify the presence and correct values of all newly added or renamed scopes, and to distinguish between similarly named but different scopes.

Integration test updates:

  • Updated integration tests to use the correct, current scopes—removing retired ones and replacing them with their documented equivalents (e.g., using ACCOUNTS instead of MARKETPLACE, and the new issuing scopes instead of ISSUING_CARD_MGMT/ISSUING_CLIENT). [1] [2]

@david-ruiz-cko
david-ruiz-cko requested a review from a team September 15, 2026 12:48
@agent-wall-e

agent-wall-e Bot commented Sep 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff only updates enum constants in OAuthScope (adding/removing/renaming string values), updates tests, and bumps the version number—no new endpoints, external integrations, persisted data, auth changes, or background processes are introduced.

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionThe diff only updates enum constants in OAuthScope (adding/removing/renaming string values), updates tests, and bumps the version number—no new endpoints, external integrations, persisted data, auth changes, or background processes are introduced. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Sep 15, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only updates enum constants in OAuthScope (adding/removing string values), adjusts tests, and bumps the version number—no new endpoints, external integrations, persisted data, auth changes, or background processes are introduced.

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 2


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Sep 15, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionThe PR only updates enum constants in OAuthScope (adding/removing string values), adjusts tests, and bumps the version number—no new endpoints, external integrations, persisted data, auth changes, or background processes are introduced. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The PR only updates an enum's string constants and version number, adds/removes enum values, and updates tests—no new endpoints, persisted data, auth changes, external integrations, or new abstractions are introduced.

wall-e 2026.06.19-02 · policy 376219bc71e6…

@david-ruiz-cko
david-ruiz-cko merged commit a54be9d into master Sep 16, 2026
6 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/8.2.1 branch September 16, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants