Conversation
importTaKey() shares one pair of bindValue() calls between its INSERT and its UPDATE, but the two take their parameters in opposite order: the INSERT is (item, value) while the UPDATE is "SET value = ? WHERE item = ?". Replacing an existing tls-auth key therefore wrote the item id into the value column and looked the row up by matching the integer item column against the base64 key data. No row matches on SQLite, and PostgreSQL rejects the comparison outright, so the stored key was never replaced and the user was told the import had failed. Bind each branch separately.
chris2511
approved these changes
Aug 11, 2026
Author
|
The macOS job failure looks unrelated to this change. My commit only reorders two bindValue() calls in lib/pki_x509.cpp. That file The other jobs were cancelled when this one failed, so they have no result yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
importTaKey() shares one pair of bindValue() calls between its INSERT and its UPDATE, but the two take their parameters in opposite order: the INSERT is (item, value) while the UPDATE is
"SET value = ? WHERE item = ?".
Replacing an existing tls-auth key therefore wrote the item id into the value column and looked the row up by matching the integer item column against the base64 key data. No row matches on SQLite, and PostgreSQL rejects the comparison outright, so the stored key was never replaced and the user was told the import had failed.
Bind each branch separately.