Repository navigation
i18n: add Traditional Chinese (zh-Hant) translation - #46
Open
monarchsofchaos004-gif wants to merge 1 commit into
Open
monarchsofchaos004-gif wants to merge 1 commit into
monarchsofchaos004-gif wants to merge 1 commit into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Type
Summary
Adds a Traditional Chinese (Taiwan wording) UI translation, following the steps you outlined in #45 and the translation section of CONTRIBUTING:
app/src/main/res/values-b+zh+Hant/strings.xml: new, translated from the Englishvalues/strings.xmlondevapp/src/main/res/xml/locales_config.xml: registerszh-HantSettingsScreen.kt: addsAppLanguageOption("zh-Hant", R.string.settings_app_lang_zh_hant)toAPP_LANGUAGE_OPTIONS(and drops the "zh-TW" item from the "future" comment)values/strings.xml: addssettings_app_lang_zh_hant=繁體中文as the language label,translatable="false"likesettings_app_lang_arResource keys, placeholders and escapes are kept as they are, and
translatable="false"entries are omitted.Coverage: 2464 / 2464 translatable strings (100%).
Refs #45
Self-test
Checked locally against
values/strings.xml:The repo's own CI workflow (
Build debug APK) passes on my fork with these changes.Screenshots
I'll add Home and Settings screenshots in Traditional Chinese in a comment.
Notes
normalize()inAppLanguageSelectormatches a system tag such aszh-Hant-TWby its primary subtag, so it would resolve to the firstzhentry (zh-CN). I left it untouched here; happy to adjust it if you want.