fix(compaction): do not forward agent tools to summarization - #1069
Open
leeseunguk wants to merge 1 commit into
Open
fix(compaction): do not forward agent tools to summarization#1069leeseunguk wants to merge 1 commit into
leeseunguk wants to merge 1 commit into
Conversation
Summarization is a prose-only call. Copying pi.getActiveTools() into snapshot.tools lets tool-preferring models end the summary with stopReason: toolUse and no text, which senpi rejects as empty-summary and leaves the session above the compaction threshold. Fixes code-yeongyu#1067
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarization copied the live agent tool list into the summarizer request. Tool-preferring models (observed: openai-codex/gpt-5.6-sol) then ended the summary with
stopReason: toolUseand no text. senpi treats that asempty-summary, rejects compaction, and leaves the session above the threshold.This makes
getSummarizationTools()return[]. Summarization is a prose-only call.Fixes #1067
Test plan
bun test test/compaction/summarization-no-tools.test.tsstopReason: toolUse/ empty-summary.Summary by cubic
Prevents tool-only summaries during compaction by not forwarding agent tools to the summarizer. Previously we copied the live tool list; now
getSummarizationTools()returns[], so tool‑preferring models no longer stop withtoolUseand empty text, and compaction can proceed.compactionSummarizationTools()that always returns[]and wires it intogetSummarizationTools().changes.md.Written for commit 35d9f06. Summary will update on new commits.