Repository navigation
Fix stale application status updates in UI - #5742
shivanshmishra54 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This reverts commit 85ceafe.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Events are already returned in a sorted fashion by the backend (see https://github.com/codecentric/spring-boot-admin/blob/master/spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/server/eventstore/ConcurrentMapEventStore.java#L79) so, unless I'm missing something, I can't see how this should help. |
|
Hi @shivanshmishra54, thanks for taking the time to look into this and for adding a regression test. I'm going to close this PR, for these reasons: 1. The ordering guarantee belongs on the server. 2. The guard would cause regressions.
3. It doesn't fix #4599. Where a contribution would help
You're welcome to open a new PR for any of these. Thanks again! |
Fixes #4599\n\nApplication snapshots received through the SSE stream were applied without checking their status timestamp. An older snapshot could therefore overwrite a newer status and make a healthy application appear DOWN in the UI.\n\nThis change ignores an incoming snapshot when its application status timestamp is older than the currently displayed snapshot. A regression test covers a newer DOWN snapshot followed by an older UP snapshot.\n\nValidation:\n- npm run test -- --run src/main/frontend/store.spec.ts\n- npm run lint (pre-existing warnings only)\n- npm run build