fix(junit): report suite hook failures#5656
Open
morgan-coded wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5645.
The JUnit reporter was building XML only from
result.tests, which misses failures from suite-level Mocha hooks such asBeforeSuite,AfterSuite, and helper suite hooks.This follows the Mocha runner
failevent approach that mirao described on the issue.This captures those suite-level hook failures from Mocha's runner
failevent and adds them as failed testcase entries before the XML is built, while leaving per-test hook failures alone because those are already reported through normal test results.Verified with:
npx mocha test/unit/junitReporter_test.js --reporter @testomatio/reporter/mocha --timeout 10000npm run lintnpm run test:unitnpm run test:runner