Skip to content

Define explicit Zeitwerk namespaces for Renderer and Adapters #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n-rodriguez wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Define explicit Zeitwerk namespaces for Renderer and Adapters #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/simple_navigation/adapters.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

module SimpleNavigation
# Explicit namespace for the framework adapters living in adapters/.
#
# Without this file Zeitwerk would infer SimpleNavigation::Adapters as an
# implicit namespace from the adapters/ directory. That inference is not
# resolved reliably on every runtime (e.g. JRuby, see issue #237), so the
# namespace is defined explicitly here.
module Adapters
end
end
12 changes: 12 additions & 0 deletions lib/simple_navigation/renderer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

module SimpleNavigation
# Explicit namespace for the renderers living in renderer/.
#
# Without this file Zeitwerk would infer SimpleNavigation::Renderer as an
# implicit namespace from the renderer/ directory. That inference is not
# resolved reliably on every runtime (e.g. JRuby, see issue #237), so the
# namespace is defined explicitly here.
module Renderer
end
end