Repository navigation
🤖 perf: document Report slowness and synthetic tape replay on the Profiling Xum page - #5625
Conversation
…ss markers The E2E fixture sets XUM_E2E and the replay spec sets XUM_REPLAY_HARNESS. The refusal now points to make perf-tape-replay without naming the variables.
Adds a Report slowness section (bundle contents, limits, partial path redaction), a contributor section for make perf-tape-replay, and makes the report the first item of the performance issue checklist. The keybinds page links to the profiling page instead of repeating it.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Documents two merged perf features on the Profiling Xum page (
docs/reference/profiling.mdx), and fixes one wrong runtime message.## Report slownesssection.xum api perf-reports create.~/.xum/perf/reports/<id>/.snapshot.json,trace.json,environment.json,README.txt,captures/withmanifest.json,hangs.jsonandapp-metrics.json. The last two are desktop only.~(🤖 perf: F4 "Report slowness" sanitizer follow-ups #5561).docs/config/keybinds.mdxkeeps the shortcut and links here, so each fact has one home.make perf-tape-replayruns and where its output goes.XUM_E2E=1andXUM_REPLAY_HARNESS=1are set, and the test harness sets them, not the Makefile. The app blocks renderer requests, while the harness takes background network offline. Tape paths are checked for absolute local syntax only:..and symlinks are accepted.sessionTapeReplaySource.ts): it now says "Run make perf-tape-replay to use the isolated replay harness." The old text claimed the make target sets the markers. The existing test matches only/only inside the perf harness/, which is unchanged, so this PR adds no exact-copy test.Validation
xum serverwith a temporaryXUM_ROOT:perf-reports createwith the experiment off fails withPRECONDITION_FAILEDand the documented message.README.txt,captures/withmanifest.json,environment.json,snapshot.jsonandtrace.json. Folders are 0700 and files 0600.environment.jsonkeys match the page, and the home path appears nowhere in the bundle.CONFLICTwith "a slowness report is already being written".make static-check-fullpasses, includingmintlify broken-links.sessionTapeReplaySource.test.tspasses (25 tests).Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$30.02