libimage: clarify local image transport error - #2549
Closed
Rajkaran-122 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Rajkaran Yadav <yadavrajkaran854@gmail.com>
|
This repository has been migrated to https://github.com/containers/container-libs. Please open your PR there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the error returned by
Runtime.LookupImagewhen a local image lookup is attempted using a non-storage transport such asdocker://.Previously the error identified the unsupported transport but did not explain how to refer to a locally stored image. This change preserves the existing rejection while adding guidance to remove the transport prefix.
Changes
Runtime.LookupImageTestLookupImageto coverdocker://referencesTesting
The targeted test exceeded the local execution limit because the existing test pulls Alpine.
Also verified: