Skip to content

secex: switch to pvimg in butane for fake secure VM#4599

Merged
nikita-dubrovskii merged 1 commit into
coreos:mainfrom
nikita-dubrovskii:secex_fake_vm_bump
Jul 21, 2026
Merged

secex: switch to pvimg in butane for fake secure VM#4599
nikita-dubrovskii merged 1 commit into
coreos:mainfrom
nikita-dubrovskii:secex_fake_vm_bump

Conversation

@nikita-dubrovskii

@nikita-dubrovskii nikita-dubrovskii commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

el9,el10 and rhel-9.6 now ship s390utils-base >= 2.36.0, so switch from the obsolete genprotimg tool to pvimg. This change doesn't affect official qemu-secex builds, but only local dev builds.

Summary by CodeRabbit

  • Bug Fixes
    • Updated secure boot image generation to use the current image creation tool.
    • Preserved existing inputs and output behavior while adding explicit image creation options.

el9,el10 and rhel-9.6 now ship s390utils-base >= 2.36.0, so switch from
the obsolete `genprotimg` tool to `pvimg`. This change doesn't affect
official qemu-secex builds, but only local dev builds.
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Enterprise

Run ID: 6a935256-723a-4aea-83d1-f2832febdff4

📥 Commits

Reviewing files that changed from the base of the PR and between cbcb7c7 and 591e55d.

📒 Files selected for processing (1)
  • src/secex-genprotimgvm-scripts/genprotimg.bu

📝 Walkthrough

Walkthrough

The inline do_genprotimg script now invokes pvimg create instead of genprotimg to generate se.img, using the same image inputs and output path.

Changes

Image generation

Layer / File(s) Summary
pvimg image creation
src/secex-genprotimgvm-scripts/genprotimg.bu
The inline script replaces the genprotimg invocation with pvimg create, retaining the vmlinuz, initrd.img, parmfile, hostkey, and se.img inputs and output while adding the new command options.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing genprotimg with pvimg in the Butane config for the fake secure VM.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rolv-Apneseth Rolv-Apneseth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c4rt0 c4rt0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nikita-dubrovskii
nikita-dubrovskii merged commit a51f055 into coreos:main Jul 21, 2026
9 checks passed
@nikita-dubrovskii
nikita-dubrovskii deleted the secex_fake_vm_bump branch July 21, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants