4255 first pass - #48
Closed
lorihughes wants to merge 4 commits into
Closed
Conversation
Collaborator
|
Given 4255 has been updated, I'll cherry pick these changes into the doc (easier than just merging the PR) |
Collaborator
|
I pulled the relevant parts of this PR into the file manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass edits through part of section 5, then I stopped because this paper needs a thorough rewrite. The paper contains repeated sentence fragments, nonsensical phrasing, vague pronoun/antecedent situations, etc.
Author comments from Claude:
Editorial notes for the author — P4255R0
Note: the editing pass covered the abstract through §5 step 4 and stopped. The first two notes concern the paper as a whole and should be settled before further line editing.
A sentence-level audit is needed, and it outranks the length problem. The most common line-level defect is verbless fragments used for emphasis — six instances in four sections, recurring throughout the unedited remainder. That much is mechanical: one pass, one rule, every emphatic beat becomes a clause with a subject and a verb. The more consequential finding is what sat underneath several of them.
inline_schedulersender: "This sender is the standard's own facility for inline completion, not a hand-rolled type, but the facility P3552R3 provides for exactly this case." The "but" contrasts nothing — the clause after it restates the clause before it. And the sentence appears to attributeinline_schedulerto P3552R3, when the facility comes fromstd::executionand what P3552R3 contributes is theawait_transformbypass. The paper's own §5 step 1 describes it correctly.as_awaitableis stated plainly and narrowed correctly.The paper makes its case by §7 and continues for another 4,000 words. Sections 1 through 7 are the argument: seven numbered steps for the sender path against three for the awaitable path, each cited to a clause, with §7's table setting the per-write costs side by side. A reader who stops at §7 has the finding, the evidence, and the means to check it.
as_awaitablecustomization point, the unshipped-P4126R2 dependency, the claim that step counts are not runtime costs, and possibly the optimizer objection.§3, the emphasized closing line — remove the emphasis or cut the sentence. Currently The algorithm was compiled once. The execution model was chosen by the linker. (changed from bold to italic in this pass, which reduces weight without addressing the issue).
await_ready." in §10, and in both places the surrounding text has already established the point.§4, the affordances sentence — the list structure cannot be recovered from the punctuation. Currently: "The comparison that follows grants senders every affordance:
inline_scheduler::schedule()as the sender - the standard's own facility for inline completion[5] - synchronous completion insidestart, and the minimalcompletion_signatures<set_value_t()>."§5, the
inline_schedulersentence — unresolved. Detailed in the first note above. Three questions need answering before it can be rewritten: whether the sentence stays at all, which document providesinline_scheduler, and what the "but" is meant to contrast. The preceding paragraph already establishes thatstartcallsset_valueimmediately, and §4 already states that the comparison grants senders the standard's own facility — so the sentence may be redundant even once corrected.