Extract helper methods for formatter string interpolation - #16720
Merged
straight-shoota merged 3 commits intoMar 17, 2026
Merged
straight-shoota merged 3 commits into
straight-shoota merged 3 commits into
Conversation
straight-shoota
force-pushed
the
refactor/formatter-string_interpolation
branch
from
March 10, 2026 16:48
79f5655 to
2d04268
Compare
ysbaddaden
approved these changes
Mar 16, 2026
straight-shoota
added a commit
that referenced
this pull request
Mar 19, 2026
…16747) Continuation of #16720, but extracted into a separate commit for a cleaner diff because of overlap. This is a plain refactoring to extract behaviour into helper methods. It helps structure the code and prepares for reusing these helpers to implement interpolation for string array literals ([RFC 0021](crystal-lang/rfcs#21)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a plain refactoring to extract behaviour into helper methods. It helps structure the code and prepares for reusing these helpers to implement interpolation for string array literals (RFC 0021).