Validate HTTP::Request#method - #17255
Merged
straight-shoota merged 4 commits intoAug 26, 2026
Merged
straight-shoota merged 4 commits into
straight-shoota merged 4 commits into
Conversation
straight-shoota
added
kind:bug
ysbaddaden
approved these changes
Aug 21, 2026
Collaborator
|
Sigh, |
ysbaddaden
approved these changes
Aug 25, 2026
| {{table}}.to_slice | ||
| {% end %} | ||
| {% else %} | ||
| table = Slice(UInt8).new(256) |
Collaborator
There was a problem hiding this comment.
Polish: indentation is weird.
Member
Author
There was a problem hiding this comment.
That's the formatter acting weird. I don't think it's worth it to wrangle about it 🤷
I need to open an issue for that.
Collaborator
|
With RFC 0030 I wonder if we really need the fallback? |
Member
Author
|
Right now we need it to merge this PR. We can drop it after adjusting the CI workflow. |
straight-shoota
had a problem deploying
to
github-write
August 26, 2026 17:14 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP::Request.newand#method=should not allow arbitrary strings. This patch verifies that the given method is a valid HTTP token.Invalid tokens would corrupt the HTTP message format.