release: avoid duplicate Docker browser install - #2864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The v0.8.2 Dockerfile installs Chromium first through
npx playwright install --with-depsas root and then throughd2 init-playwrightas the runtime user, so the browser is downloaded into two separate user caches.This changes the root step to Playwright's dependency-only installation. The existing non-root initialization remains the single browser installation, preserving PNG export behavior.
The workflow reports measured image sizes rather than enforcing a fixed ceiling.
Measured result
Compressed OCI layers, compared with the currently published v0.8.2 images:
Both native jobs passed D2 version, SVG, and PNG rendering smoke tests.
Validation
go test ./ci/release/docker -count=1go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/docker-image-smoke.ymlCOLOR=1 CI_FORCE=1 ./make.sh