Skip to content

ci: add scheduled workflow to alert translators of English rule changes - #758

Open
Johannes-spsm wants to merge 2 commits into
mainfrom
add-translator-alert
Open

ci: add scheduled workflow to alert translators of English rule changes#758
Johannes-spsm wants to merge 2 commits into
mainfrom
add-translator-alert

Conversation

@Johannes-spsm

Copy link
Copy Markdown
Collaborator

Closes #496

@moritz-gross

Copy link
Copy Markdown
Collaborator

as I understand it after some research, the cron means "14:03 UTC on the 1st and 15th of every month"
I had trouble understanding what 1,15 means at first.
maybe add this as a brief comment after the expression?

@rileeki rileeki moved this from Triage to In review in MathCAT Project Board Sep 9, 2026
@moritz-gross

Copy link
Copy Markdown
Collaborator

I'm generally much more comfortable with Python compared to JS.
Here, is the selling point for JS that github-script makes working with the GitHub API easier?

All things being equal, I'd prefer Python otherwise as a) at least Neil and I already know it well and b) it's also what's used for infra-related code in MathCAT anyway.

If the GitHub API integration is worth it though, we can definitely keep it.

@NSoiffer

Copy link
Copy Markdown
Collaborator

@moritz-gross: This isn't JS, at most it is a shell script which I believe is standard for this. To me the question is whether this is helpful or will noise because translators might only be able to work on this once/month of less and when they do work, they would run the audit tool (hopefully). I lean towards this being useful, but I'd like to get feedback. @MartheGjelstad, thoughts?

@moritz-gross

Copy link
Copy Markdown
Collaborator

@moritz-gross: This isn't JS, at most it is a shell script which I believe is standard for this. To me the question is whether this is helpful or will noise because translators might only be able to work on this once/month of less and when they do work, they would run the audit tool (hopefully). I lean towards this being useful, but I'd like to get feedback. @MartheGjelstad, thoughts?

it's both. in the run block, it is shell script, but script uses JS. A bit further down in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Alert Translators on English File Changes

4 participants