ENH: add top_k#446
Open
ev-br wants to merge 1 commit into
Open
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Array API-compatible top_k wrapper to the array_api_compat.torch namespace, mapping the standardized signature to torch.topk.
Changes:
- Introduces
top_k(a, k, *, axis, mode, **kwargs)wrapper in the Torch backend. - Validates
modeand forwards arguments totorch.topk. - Exports
top_kvia the Torch backend__all__.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+944
to
+961
| def top_k( | ||
| a: Array, | ||
| k: int, | ||
| /, | ||
| *, | ||
| axis: int =-1, | ||
| mode: Literal["largest", "smallest"] = "largest", | ||
| **kwargs | ||
| ) -> tuple[Array, Array]: | ||
| if mode not in ["largest", "smallest"]: | ||
| raise ValueError(f"Invalid {mode = }.") | ||
| return torch.topk( | ||
| a, | ||
| k, | ||
| dim=axis, | ||
| largest = (mode == "largest"), | ||
| **kwargs | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add basic
top_kwrappers, per data-apis/array-api#722-tests tracker: data-apis/array-api-tests#438
torchnumpycupydaskSupersedes and closes gh-158
To test locally: with this PR and data-apis/array-api-tests#438, use