ENH: add nanmin#804
Open
OmarManzoor wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@lucascolley I added one of these for a start. I think after we finalize one of them the others can follow along. |
lucascolley
reviewed
Jun 29, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
there are a few merge conflicts
| return a | ||
|
|
||
|
|
||
| def nanmin( # numpydoc ignore=PR01,RT01 |
Member
There was a problem hiding this comment.
whereabouts did you take this implementation from?
Contributor
Author
There was a problem hiding this comment.
scikit-learn directly. As for how that is implemented there I am not exactly sure.
Member
There was a problem hiding this comment.
would be good to check the history there
Contributor
Author
There was a problem hiding this comment.
https://github.com/scikit-learn/scikit-learn/pull/26243/changes
This is the actual PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #789
nanmin