Repository navigation
feat: unified structured logger from lib-node 3 - #37
Merged
Merged
Conversation
- @data-fair/lib-express 2 and @data-fair/lib-node 3, pino-pretty in dev - console.* calls in api/ replaced by log.* with static codes, no-console lint rule - EVENTS_LOG_LEVEL removed from the test script - fix browser reconnection (exports.start() does not exist in ESM) - fix animation debug lines that were never written - README: logging section Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move capture to the logger shared by the data-fair stack (
@data-fair/lib-node/log.js), as done in agents.@data-fair/lib-express2 and@data-fair/lib-node3,pino-prettyas dev dependency for pretty output in devconsole.*inapi/replaced bylog.*with static codes (start-process,stop-process,config-no-auth,browser-disconnected,contexts-pool-drain,browser-restart,page-console-parse,page-clean), enforced by ano-consolelint ruleEVENTS_LOG_LEVELremoved from the test scriptexports.start(), which does not exist in ESMWhy: one structured logging convention across the data-fair services: JSON lines in production,
df_logsmetric, implicit context.Heads-up:
disconnectedhandler (probably crashing the process); it now actually reconnects in-process, a path that never ran before.