Conversation
Signed-off-by: Suraj Shrestha <suraj.shrestha@databricks.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2658 +/- ##
=======================================
Coverage 71.31% 71.31%
=======================================
Files 112 112
Lines 10122 10125 +3
Branches 1111 1111
=======================================
+ Hits 7218 7221 +3
Misses 2690 2690
Partials 214 214 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
✅ 182/182 passed, 8 flaky, 2 skipped, 2h25m28s total Flaky tests:
Running from acceptance #5452 |
Collaborator
|
The changes LGTM. @surajs-db, can you please address the issues that are making |
m-abulazm
requested changes
Sep 18, 2026
|
|
||
| class MSSQLConnector(DatabaseConnector): | ||
| @staticmethod | ||
| def odbc_value(value: str) -> str: |
Contributor
There was a problem hiding this comment.
I would rename to something more descriptive e.g. escape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Fixes the Lakebridge MSSQL connection test for passwords containing ODBC-special characters, including ?.
When configuring an on-premises MSSQL source, a password containing ? was inserted directly into the ODBC connection string. The mssql_python parser interpreted the character as connection-string syntax and failed with:
ConnectionStringParseError: Incomplete specification: keyword '?' has no value (missing '=')
This prevented configure-database-profiler from completing the MSSQL connection test.
Relevant implementation details
Formats MSSQL password values with odbc_value before constructing the connection string, so special characters are treated as password data rather than connection-string delimiters.
Caveats/things to watch out for when reviewing:
Linked issues
Resolves #..
Functionality
databricks labs lakebridge ...Tests