Repository navigation
Test Excel workbooks with format: xlsx - #1720
Draft
nicolehazel wants to merge 1 commit into
Draft
nicolehazel wants to merge 1 commit into
nicolehazel wants to merge 1 commit into
Conversation
Read each sheet through DuckDB's excel extension, one sheet per schema named by its physicalName. The sheet is read typed and as text, lined up row by row, so Excel dates arrive as dates and a cell of the wrong type fails its column's type check. Closes datacontract#1717 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1717
Adds
format: xlsxtodatacontract test, read through DuckDB's excel extension, with one sheet per schema named by itsphysicalName.Each sheet is read twice and the reads are lined up row by row: once typed, so Excel dates (numbers with a date format) arrive as dates, and once as text, so a cell of the wrong type is still seen. A type check per column counts the cells that have a value but not the contract's type.
Possible follow-up: show the offending cells under
--include-failed-samples, which today samples only missing, invalid and duplicate counts.uv run pytest)uv run ruff check --fix && uv run ruff format)Co-authored by a human (@nicolehazel) and Claude Code.