feat(sitemap): use udata generated sitemap - #1176
Merged
Merged
Conversation
maudetes
commented
Jul 30, 2026
| expect(locCount).toBe(3) | ||
| }) | ||
|
|
||
| test('omits the external sitemap URL when NUXT_SITEMAP_INDEX_URL is not set', async ({ page }) => { |
Contributor
Author
There was a problem hiding this comment.
I don't think it's worth adding a step to test it explicitly in CI?
Contributor
|
Claude is not sure it's allowed to reference an index inside an index, but it may be better to just reference two sitemaps in our robots.txt (in infra) Something like: |
Contributor
Author
Hmm, indeed when looking it up again, I find contradictory information on nested sitemaps 😓 Let's go for the robots approach, I liked the single entry point but it's not worth the trouble. I've removed any reference to udata sitemap in 8113fe8. |
ThibaudDauce
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following opendatateam/udata#3830
Both udata and cdata sitemaps index will be exposed in robots.txt.