Fix empty plots for echem block when the data is all rest cycles - #2000
Open
be-smith wants to merge 3 commits into
Open
Fix empty plots for echem block when the data is all rest cycles#2000be-smith wants to merge 3 commits into
be-smith wants to merge 3 commits into
Conversation
be-smith
changed the base branch from
main
to
ml-evs/bump-pydantic-final-final
August 10, 2026 20:06
be-smith
marked this pull request as ready for review
August 12, 2026 10:08
ml-evs
changed the base branch from
ml-evs/bump-pydantic-final-final
to
OMWalmsley/location-route-and-location-trait
August 12, 2026 13:36
ml-evs
force-pushed
the
bes/empty_echem_plot_fix
branch
from
August 12, 2026 15:24
9e7402e to
c35a962
Compare
datalab
 |
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bes/empty_echem_plot_fix
|
| Run status |
|
| Run duration | 16m 42s |
| Commit |
|
| Committer | Ben Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
94
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
bes/empty_echem_plot_fix
branch
from
August 13, 2026 22:50
c35a962 to
e53a6c7
Compare
…me against voltage. Raise useful error for dQ/dV, cycle summary, dV/dQ rather than render meaningless plots.
…lot for this file is voltage against time. Add tests to ensure dQ/dV, dV/dQ and cycle summary modes error properly
ml-evs
force-pushed
the
bes/empty_echem_plot_fix
branch
from
August 13, 2026 23:14
e53a6c7 to
f6480d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## OMWalmsley/location-route-and-location-trait #2000 +/- ##
================================================================================
+ Coverage 80.34% 80.36% +0.02%
================================================================================
Files 84 84
Lines 7841 7849 +8
================================================================================
+ Hits 6300 6308 +8
Misses 1541 1541
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to see if the echem file is all rest, defined by having all 0's as capacity values. In this case voltage against time will be plotted instead by default to prevent not rendering a plot. Also raises a warning explaining that there is no charge/discharge cycles detected in the data.
Also adds a synthetic all rest ivium file and uses it to run tests checking these new features.