You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android: no 'error' event, so addRecordingErrorListener never fires there #447
iOS declares and emits an error event for failures that happen while recording is already running — the kind that cannot reject a call because the call already returned. AudioStudioModule.swift:
AUDIO_STREAM_ERROR_EVENT is for the streaming/decoding API, not for a live recording going wrong.
Impact
addRecordingErrorListener() (added alongside the #420 fix) is typed as cross-platform but is inert on Android. A caller who subscribes to detect a degraded recording gets silence there, which reads as "healthy" — the more dangerous failure mode, since it is the exact signal they added the listener to receive.
The doc comment says iOS-only, but a doc comment is weaker than the type.
Suggested fix
Add the event to Android's Events(...) and emit it wherever a live recording degrades without failing a call. Worth auditing what those sites are — Android's silent-failure paths are not necessarily the same as iOS's.
Once both platforms emit, drop the iOS-only caveat from the listener's docs.
Activity
fix(audio-studio/ios): recover the primary WAV when a write fails (#448)
fix(audio-studio/android): reclaim recorders on failed init, emit the…
ci: only validate issues from people without write access (#471)
fix(audio-studio/android): reclaim recorders on failed init, emit the…