Skip to content

CI gaps: plugin/src is untypechecked, and issue-validator uses deprecated action majors #456

Closed

Description

@abretonc7s

Two things found while adding the first test workflow in #453, both pre-existing and left out of it to keep that PR to one job.

plugin/src evades typechecking

packages/audio-studio/tsconfig.json excludes plugin/src, and jest.config.js disables ts-jest diagnostics. So a type error in the Expo config plugin — the code that rewrites native manifests during prebuild — fails nothing, in CI or locally.

Suggested: add tsc --noEmit -p packages/audio-studio/plugin/tsconfig.json to the JS job. It passes today, so this is about keeping it that way.

Deprecated action majors

.github/workflows/issue-validator.yml uses actions/checkout@v3 and actions/github-script@v6, both on runtimes GitHub has deprecated. tests.yml has none.

Prove the update by running the validator against a disposable issue edit — that workflow is triggered by issue events, so it can be exercised without touching code.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions