You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
sherpa-onnx.rn docs describe files and facts that no longer hold #458
Found while surveying old-architecture code for #457. Both verified.
docs/INTEGRATION_TESTING.md points at a deleted file
Lines 11 and 48 reference ArchitectureCompatibilityTest.kt, deleted in #434 along with ArchitectureSpecificTest.kt (637 lines of old-architecture detection, removed once the repo went new-architecture only). The doc still presents it as the way to verify architecture coverage, and gives a connectedAndroidTest --tests "*ArchitectureCompatibilityTest" command that now matches nothing.
The module name in that command is also stale — it says :siteed-expo-audio-studio, and the real one is :siteed_sherpa-onnx.rn.
It does not. SherpaOnnxModule extends ReactContextBaseJavaModule and SherpaOnnxPackage implements ReactPackage — both live and registered. Under RN 0.86's interop layer that is how the module registers, so the code is correct and the documentation is wrong.
This one has teeth: I nearly used that claim as evidence that the Kotlin module was dead. Running the grep is what stopped me.
Suggested
Rewrite both to describe what exists. A check that documented paths resolve would catch the first class of error cheaply — the second needs someone to re-run the assertion.
Activity
ci: only validate issues from people without write access (#471)