Skip to content

fix: redact tool arguments from invocation errors - #13809

Closed
laoyyu wants to merge 2 commits into
deepset-ai:mainfrom
laoyyu:fix/13786-redact-tool-inputs
Closed

laoyyu wants to merge 2 commits into
deepset-ai:mainfrom
laoyyu:fix/13786-redact-tool-inputs

Conversation

@laoyyu

@laoyyu laoyyu commented Nov 19, 2026 •

Copy link
Copy Markdown

Fixes #13786

Summary

  • Keep model-generated tool arguments in invocation diagnostics.
  • Redact only parameters injected from Agent state or runtime context.
  • ComponentTool conversion errors identify the parameter and validation type without echoing the rejected value.
  • ComponentTool debug logs list input names instead of values.
  • Added sync, async, and conversion-path regressions.

Validation

  • Focused TestRunToolErrorHandling: 16 passed
  • Focused component logging test passed
  • Ruff check and format passed for changed files

@laoyyu
laoyyu requested a review from a team as a code owner November 19, 2026 00:43
@laoyyu
laoyyu requested review from sjrl and removed request for a team November 19, 2026 00:43
@vercel

vercel Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@laoyyu is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

CLAassistant commented Nov 19, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HaystackBot

Copy link
Copy Markdown
Contributor

Hi @laoyyu, thanks a lot for your contribution! 🙏

We noticed that the Contributor License Agreement (CLA) check (license/cla) hasn't passed yet, so we've temporarily moved this PR to draft and paused the review assignment.

To get your PR reviewed, please sign the CLA via the link in the license/cla check below (or in the CLA bot comment). As soon as the check turns green, this PR will automatically be marked ready for review again and a reviewer will be re-assigned.

@HaystackBot
HaystackBot removed the request for review from sjrl November 19, 2026 01:51
@HaystackBot HaystackBot added the cla-pending PR is in draft until the contributor signs the CLA label Nov 19, 2026
@HaystackBot
HaystackBot marked this pull request as draft November 19, 2026 01:51
@HaystackBot
HaystackBot marked this pull request as ready for review November 19, 2026 01:54
@HaystackBot
HaystackBot requested a review from sjrl November 19, 2026 01:54
@HaystackBot HaystackBot removed the cla-pending PR is in draft until the contributor signs the CLA label Nov 19, 2026
@HaystackBot

Copy link
Copy Markdown
Contributor

Thanks for signing the CLA, @laoyyu! 🎉 This PR is now ready for review again and the reviewer has been re-assigned.

@sjrl

sjrl commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! As mentioned in #13786 this is something we'd like to handle internally, so I'll close this one.

@sjrl sjrl closed this Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hidden state values can appear in Agent tool-error messages and logs

4 participants