Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped addition includes regression coverage for intended access and exact-host restrictions, with no unresolved findings.
No open issues 🎉
What changed in this PR
Adds Percona’s public Helm chart repository to the proxy’s egress defaults so Dependabot can fetch its chart index.
Changes:
- Allows only the exact host
percona.github.io, without widening access to other GitHub Pages hosts. - Adds regression probes for the chart index and for blocking child subdomains.
| File | Description |
|---|---|
| internal/handlers/egress_allowlist_test.go | Adds positive access and negative child-subdomain probes. |
| internal/handlers/egress_allowlist_defaults.yaml | Adds Percona’s exact hostname to the Helm defaults. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Dependabot helm jobs can't read the chart index of the Percona Helm chart repository: the proxy blocks
percona.github.io(egress not allowlisted, 403). This adds it toecosystem_default_domains.helm.percona.github.ioindex.yaml; tarballs are ongithub.com(already allowed)charts/pg-operator/README.md(helm repo add percona https://percona.github.io/percona-helm-charts/); GitHub Pages of theperconaorg;index.yamlreturns anonymous200Anything you want to highlight for special attention from reviewers?
Exact host only, no
*.github.iowidening, same form asfluent.github.io.How will you know you've accomplished your goal?
https://percona.github.io/percona-helm-charts/index.yamlinTestEgressAllowlist_AddedMissingDomainsAllowed.https://evil.percona.github.io/payloadinTestEgressAllowlist_NewEntriesDoNotWidenBeyondExactHosts. Checked that it bites: switching the entry to.percona.github.iomakes the test fail (Expected value not to be nil). Reverted afterwards.TestEgressDefaults_NoRedundantEntriespasses, so the host isn't already covered by another entry.script/testpasses locally.Checklist