feat(mgmt): add outbound SCIM configuration management wrapper#765
Open
dorsha wants to merge 6 commits into
Open
feat(mgmt): add outbound SCIM configuration management wrapper#765dorsha wants to merge 6 commits into
dorsha wants to merge 6 commits into
Conversation
Adds outboundSCIM management module with createConfiguration, updateConfiguration, deleteConfiguration, loadConfiguration, loadAllConfigurations, and setEnabled. Related: descope/etc#15987 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
🐕 Review complete — View session on Shuni Portal 🐾 |
Contributor
🐕 Suggested ReviewersThe selection covers broad areas of the pull request, including core management logic, API paths, and data types, ensuring a well-rounded review of the changes.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
![shuni-bot[bot]](https://avatars.githubusercontent.com/in/2536750?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🐕 Shuni's Review
Adds a management.outboundSCIM wrapper (create/update/delete/load/loadAll/setEnabled) over the new /v1/mgmt/outbound/scim/* endpoints, mirroring the existing outboundApplication module.
No issues found — good bones! Clean pattern reuse, consistent types, dedicated tests covering every path and body. Woof!
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Backend PR #1747 review round 3: drop id + name from OutboundSCIMConfiguration and identify the SCIM configuration by the federated SSO app id end-to-end. Create/Update/Delete/Load/SetEnabled all take appId now; the connector name is derived server-side from the app. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
management.outboundSCIMmodule withcreateConfiguration,updateConfiguration,deleteConfiguration,loadConfiguration,loadAllConfigurations,setEnabledcalling the new/v1/mgmt/outbound/scim/*endpoints on the backend (descope/backend#1747).OutboundSCIMConfiguration,CreateOutboundSCIMConfigurationRequest,UpdateOutboundSCIMConfigurationRequesttypes.outboundapplicationwrapper shape exactly.Related: descope/etc#15987
Test plan
npm run buildclean (dist/cjs/index.cjs.js + dist/index.esm.js + dist/index.d.ts emitted)npx jest lib/management/outboundscim.test.ts— 8 tests passnpx jest lib/management/— 275 tests, no regressions🤖 Generated with Claude Code