compiler: Fix handling for determining if functions on subdomains touch the halo - #2988
Open
EdCaunt wants to merge 2 commits into
Open
compiler: Fix handling for determining if functions on subdomains touch the halo#2988EdCaunt wants to merge 2 commits into
EdCaunt wants to merge 2 commits into
Conversation
mloubout
reviewed
Aug 3, 2026
| # array allocated on the SubDomain. As such, they do not represent a shift of index | ||
| # on the physical grid and can (and should) be zeroed for the purpose of determining | ||
| # if the halo is touched. | ||
| tkns_subs = {tkn: 0 for tkn in self[findex].free_symbols if isinstance(tkn, Thickness)} |
Contributor
There was a problem hiding this comment.
search(self[findex], Thickness) ?
| # on the physical grid and can (and should) be zeroed for the purpose of determining | ||
| # if the halo is touched. | ||
| tkns_subs = {tkn: 0 for tkn in self[findex].free_symbols if isinstance(tkn, Thickness)} | ||
| findex_wo_thickness = self[findex].subs(tkns_subs) if tkns_subs else self[findex] |
Contributor
There was a problem hiding this comment.
No need, subs({}) is no-op already
|
|
||
| op = Operator(eqns) | ||
|
|
||
| print(op.ccode) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2988 +/- ##
==========================================
- Coverage 83.54% 82.90% -0.64%
==========================================
Files 257 257
Lines 53906 53922 +16
Branches 4613 4613
==========================================
- Hits 45037 44706 -331
- Misses 8066 8401 +335
- Partials 803 815 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EdCaunt
force-pushed
the
halotouch-redux
branch
from
August 5, 2026 09:31
326224b to
67ec63d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.