Skip to content

#2140 just install fails since already installed#2147

Open
JoelAdbu wants to merge 4 commits into
devonfw:mainfrom
JoelAdbu:feature/2140-just-install-fails-since-already-installed
Open

#2140 just install fails since already installed#2147
JoelAdbu wants to merge 4 commits into
devonfw:mainfrom
JoelAdbu:feature/2140-just-install-fails-since-already-installed

Conversation

@JoelAdbu

@JoelAdbu JoelAdbu commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2140

Implemented changes:

  • Add override method completeRequestOption with flag --force set to allow upgrades when eyisting just.exe of different package exists.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Install uv if not already installed:
   ide install uv
  1. Install just manually via uv:
uv tool install just
  1. checkout the pr branch
  2. Run IDEasy
    • don't forget to set UV_TOOL_DIR and UV_TOO_BIN_DIR in run configurations
    • set run arguments to install just

Expected output:

No CVEs found for version 1.55.1 of tool just.
No CVEs found for version 0.11.28 of tool uv.
Resolved 1 package in 235ms
Installed 1 package in 36ms
 + rust-just==1.55.1
Installed 1 executable: just
Successfully installed just in version 1.55.1 at $IDE_HOME\projects\IDEasy\software\uv

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

- Fix detection and upgrade of manually installed just
@JoelAdbu

Copy link
Copy Markdown
Contributor Author

While investigating this issue, I found that the root cause appears to be related to UV's handling of packages that provide the same executable.
just and rust-just are different UV packages, but both install just.exe.
When a user has previously installed just manually and IDEasy later installs rust-just, UV aborts with an executable conflict unless --force is used.
This seems related to the behavior discussed in UV issue astral-sh/uv#18854 .

- fix (just): supports upgrades from manually installed just
@JoelAdbu JoelAdbu force-pushed the feature/2140-just-install-fails-since-already-installed branch from 460fb66 to d550b01 Compare July 10, 2026 08:58
JoelAdbu added 2 commits July 10, 2026 13:40
- update uv test mock to support install options
- adjust Just tests for --force installation
- add changelog for issu
@coveralls

coveralls commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29090449301

Coverage decreased (-0.04%) to 72.186%

Details

  • Coverage decreased (-0.04%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 23 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

23 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 20 80.92%
com/devonfw/tools/ide/version/VersionSegment.java 2 90.03%
com/devonfw/tools/ide/tool/just/Just.java 1 75.0%

Coverage Stats

Coverage Status
Relevant Lines: 16711
Covered Lines: 12572
Line Coverage: 75.23%
Relevant Branches: 7460
Covered Branches: 4876
Branch Coverage: 65.36%
Branches in Coverage %: Yes
Coverage Strength: 3.18 hits per line

💛 - Coveralls

@JoelAdbu JoelAdbu moved this from 🆕 New to 🏗 In progress in IDEasy board Jul 10, 2026
@JoelAdbu JoelAdbu self-assigned this Jul 10, 2026
@JoelAdbu JoelAdbu marked this pull request as ready for review July 10, 2026 11:55
@laert-ll laert-ll self-assigned this Jul 13, 2026
@laert-ll laert-ll moved this from 🏗 In progress to Team Review in IDEasy board Jul 13, 2026
@laert-ll

Copy link
Copy Markdown
Contributor

I tested this locally and ide installs just successfully even after having it installed earlier using uv. Adding the --force flag seems to fix the problem, as also hinted in the error output.

I think it's worth discussing however if --force should be in Just or in UvBasedCommandlet. I'm not sure if this problem also occurs with other uv based tools, but in that case one might consider making this solution a bit broader.

Otherwise, great work!

@JoelAdbu JoelAdbu added bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet just just task runner labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet just just task runner

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

just install fails since already installed

3 participants