2525E Types

[Nick (ingalls)]

Context

• 🚀 2525E Types in GeoJSON input

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR adds support for providing numeric MIL-STD-2525D/2525E SIDCs in GeoJSON input via the properties.type field, converting them into a basic CoT Atom type while preserving the original SIDC in milicon.

Changes:

• Add numeric SIDC detection and conversion utilities (isNumericSIDCConvertable, fromNumericSIDC) to the 2525 utility.
• Update from_geojson to accept numeric SIDCs in properties.type, map them to a-<affiliation>-<battle dimension>, and populate properties.milicon.id when not explicitly provided.
• Add test coverage for conversion behavior and non-clobbering of explicit milicon.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/from_geojson.test.ts	Adds GeoJSON-to-CoT tests covering numeric SIDC-as-type conversion and milicon preservation behavior.
test/2525.test.ts	Adds unit tests for numeric SIDC validation and mapping to CoT atom types.
lib/utils/2525.ts	Implements numeric SIDC recognition and basic conversion logic (affiliation + symbol set → battle dimension).
lib/parser/from_geojson.ts	Integrates numeric SIDC handling into GeoJSON parsing, including milicon population and type remapping.
CHANGELOG.md	Documents the new GeoJSON type numeric SIDC input behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.