Isolate worksheet-local property mappings to prevent cross-sheet metadata corruption and spurious header ingestion - #55
Open
Montana wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Homeland Security,
This PR fixes a worksheet-boundary state management defect in
TemplateReader.inventory_records()that can corrupt imported metadata or terminate Excel ingestion with aKeyError.The property mapping is currently initialized outside the worksheet loop. After processing the first inventory worksheet, subsequent worksheets inherit its column-to-property associations and bypass header initialization.
This produces three observable failures:
KeyError.The change moves
props = Noneinside the worksheet loop. Each inventory worksheet independently initializes its mapping from its own header comments and skips that header before processing records. Existing record construction and blank-row handling remain unchanged.The accompanying parametrized regression tests exercise eight combinations: identical, reordered, expanded, and reduced column layouts, each with either a populated or header-only first inventory worksheet. The fixtures also include blank rows and a non-inventory instructions sheet.
Cheers,
Michael